<html>
<head><meta charset="utf-8"><title>CI · t-cargo/PubGrub · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/index.html">t-cargo/PubGrub</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html">CI</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="213179193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213179193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213179193">(Oct 13 2020 at 16:09)</a>:</h4>
<p>I think it's nice to run CI on schedule to ensure the library continues to work with new stable/nightly releases and the latest dependencies even when it's not actively worked on it.</p>
<p>Do you agree, and if so, how frequent do you think should be enough? Most other projects seem to run theirs once a day. I think we should do it at least once a week. A poll:</p>
<ol>
<li>Daily.</li>
<li>Weekly.</li>
<li>Only on PRs.</li>
<li>Some other choice.</li>
</ol>



<a name="213179909"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213179909" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213179909">(Oct 13 2020 at 16:14)</a>:</h4>
<p>I am not worried about Rust braking us, but the dependencies may be a problem. I'd be ok with weekly.</p>



<a name="213203159"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213203159" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthieu Pizenberg <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213203159">(Oct 13 2020 at 19:07)</a>:</h4>
<p>once a week should be enough</p>



<a name="213307708"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213307708" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213307708">(Oct 14 2020 at 15:33)</a>:</h4>
<p>By the way, I just realized why <code>clippy</code> checking is better done with nightly rather than stable.<br>
If we do it on stable, than the moment a new stable releases our next scheduled CI + the next PR are almost guaranteed to break. The amount of warnings unrelated to submitted PR could possibly be substantial.<br>
If we check with nightly, than those warnings are amortized over a larger period of time and can be tackled one at a time.</p>



<a name="213307945"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213307945" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213307945">(Oct 14 2020 at 15:34)</a>:</h4>
<p>Probably the same argument can be applied to formatting, but that fixes itself with <code>cargo fmt</code> so it's not costly there.</p>



<a name="213308233"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213308233" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213308233">(Oct 14 2020 at 15:36)</a>:</h4>
<p>On the other hand the "clippy changed broke CI" can happen any time if we use nightly, and will only happen 6 weeks on stable.</p>



<a name="213308653"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213308653" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213308653">(Oct 14 2020 at 15:39)</a>:</h4>
<p>True, but I think doing tiny changes over time beats doing a lot of work once in a while. Just my experience.</p>



<a name="213308936"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213308936" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213308936">(Oct 14 2020 at 15:41)</a>:</h4>
<p>On the other hand, maybe those lints would be removed before arriving to stable.</p>



<a name="213314411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213314411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213314411">(Oct 14 2020 at 16:15)</a>:</h4>
<p>Actually I just hit such lint.</p>
<div class="codehilite"><pre><span></span><code>warning: usage of `Rc&lt;T&gt;` when T is a buffer type
  --&gt; src/internal/core.rs:23:28
   |
23 |     pub incompatibilities: Rc&lt;Vec&lt;Incompatibility&lt;P, V&gt;&gt;&gt;,
   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Rc&lt;[Incompatibility&lt;P, V&gt;]&gt;`
   |
   = note: `#[warn(clippy::rc_buffer)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#rc_buffer
</code></pre></div>



<a name="213314636"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/CI/near/213314636" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/CI.html#213314636">(Oct 14 2020 at 16:16)</a>:</h4>
<p>When I asked on Clippy channel about it, they said they downgraded it and it would have to be specifically enabled in the future.<br>
<a href="#narrow/stream/257328-clippy/topic/rc_buffer">https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/rc_buffer</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>